Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreasonably large bundle size (5MB) of web client #2

Closed
polymorpher opened this issue May 27, 2021 · 2 comments
Closed

Unreasonably large bundle size (5MB) of web client #2

polymorpher opened this issue May 27, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@polymorpher
Copy link
Owner

As I was migrating code from https://github.com/hashmesan/harmony-totp , I noticed the web-client is packing up a large number of packages. The current bundle size is >5MB. This is unacceptable for production use beyond the MVP stage. I suspect many of them are unnecessary.

I will make a note here in case anyone would be interested in helping out on this.

I have already ruled out polyfill - it is not the suspect.

image
@polymorpher polymorpher added the bug Something isn't working label May 27, 2021
@polymorpher polymorpher changed the title Bundle size of webclient Unreasonably large bundle size (5MB) of web client May 27, 2021
@polymorpher
Copy link
Owner Author

Biggest issue seems to be @truffle/contract, which takes 4MB: https://bundlephobia.com/result?p=@truffle/contract@4.3.17

Not easy to fix. Leaving it for later

image

@polymorpher
Copy link
Owner Author

The issue is now deprecated. The analysis above is now referring to the /legacy/webclient code. The new bundle (under /code/client) is ~10MB. The dependency to web3 and truffle can be potentially removed, by using Harmony JS SDK. I will post another issue.

@polymorpher polymorpher mentioned this issue Jun 24, 2021
Open
74 tasks
HYDEAI pushed a commit to HYDEAI/one-wallet that referenced this issue Aug 29, 2021
# This is a combination of 2 commits.
46385dd 
# This is the 1st commit message:

Started Apple Watch Otp Process.

# This is the commit message polymorpher#2:

Started Apple Watch Otp Process.
HYDEAI pushed a commit to HYDEAI/one-wallet that referenced this issue Aug 29, 2021
# This is a combination of 3 commits.
98c5b5c 
# This is the 1st commit message:
# This is a combination of 2 commits.
# This is the 1st commit message:

Started Apple Watch Otp Process.

# This is the commit message polymorpher#2:

Started Apple Watch Otp Process.

# This is the commit message polymorpher#2:

Started Apple Watch Otp Process.

# The commit message polymorpher#3 will be skipped:

#	Started Apple Watch Otp Process.
@polymorpher polymorpher mentioned this issue Sep 6, 2021
Closed
polymorpher added a commit that referenced this issue Dec 17, 2021
@polymorpher
Merge pull request #212 from polymorpher/state_refactor
eba481f 
State refactor #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@polymorpher