Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client v0.8.0 (wallet version 8.0) may cause funds to be unspendable and unrecoverable #72

Closed
polymorpher opened this issue Aug 10, 2021 · 1 comment

Comments

@polymorpher
Copy link
Owner

polymorpher commented Aug 10, 2021

This issue applies to wallets created by scanning a single OTP code. Double OTP wallets are not affected.

The client mistakenly creates the wallet expecting two OTPs to be used, even if the user did not tick "use second code to enhance security". As a result, the user never got a chance to scan the second OTP, but the wallet is generated in a way such that it is only usable with two OTPs. Therefore, the user would never be able to spend or recover funds in the wallet.

I have upgraded the client to version 0.8.1 (https://github.com/polymorpher/one-wallet/tree/v0.8.1). The problem no longer exists. I have added warning messages in the UI to alert users not to use the wallet if its version is 8.0.

The problem can be prevented with more thorough end-to-end testing. Since the issue was at the client side, the automated testing at core and smart contract levels are not sufficient. More automated tests should be added to the client as well.

REMEDY:

If your wallet is created with a recovery address, simply recover the funds by going to "Recovery" tab and click "Recover".

If your wallet is created without a recovery address and you have funds in that wallet, please reply below or contact me

@polymorpher
Copy link
Owner Author

Resolved and confirmed to be effective in v0.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant