Add use two otp options on create wallet #65
Conversation
code/client/src/pages/Create.jsx
Outdated
| // otpauth://TYPE/LABEL?PARAMETERS | ||
| return `otpauth://totp/${name}?secret=${b32.encode(seed)}&issuer=Harmony` | ||
| return `otpauth://totp/${name}?secret=${b32.encode(otpSeed)}&issuer=Harmony` |
There was a problem hiding this comment.
Need to use a slightly different name here. e.g. instead of ${name}, use ${name} (2nd)
There was a problem hiding this comment.
So the name is the same, but append (2nd)?
code/client/src/pages/Create.jsx
Outdated
| } else if (doubleOtp && !settingUpSecondOtp) { | ||
| setSection(sectionViews.setupSecondOtp) | ||
|
|
||
| setName(generateNewOtpName()) |
There was a problem hiding this comment.
should not generate a new name. The name is the (local) name of the wallet to help the user identify the wallet. It should be the same for both OTP entries on the authenticator, and the same name should be stored in redux state
There was a problem hiding this comment.
Do you mean the name is the same, but the second one has (2nd) appended?
code/client/src/pages/Create.jsx
Outdated
| @@ -232,6 +272,34 @@ const Create = () => { | |||
| </Row> | |||
| </Space> | |||
| </Row> | |||
| <Row justify='center'> | |||
| <Checkbox onChange={() => setDoubleOtp(!doubleOtp)}> | |||
| <Hint>Use two One Time Passwords for enhanced security</Hint> | |||
There was a problem hiding this comment.
Should let user know what to expect - i.e. they will need to scan again on the next page. Otherwise they tick the box and nothing happens
code/client/src/pages/Create.jsx
Outdated
| } else if (doubleOtp && !settingUpSecondOtp) { | ||
| setSection(sectionViews.setupSecondOtp) | ||
|
|
||
| setName(`${name} (2nd)`) |
There was a problem hiding this comment.
It would be incorrect to change the name state variable because the wallet would be saved as ${name} (2nd) in redux
There was a problem hiding this comment.
Good point. So we still want to save the name as original name in the state, but the authenticator would have a different name for the second OTP (that is only append (2nd) text).
…t-security-frontend
…nto client-security-frontend
| const resetOtp = () => { | ||
| setOtpInput('') | ||
| setOtp2Input('') |
There was a problem hiding this comment.
If we are focusing on OTP 1 input after reset, we don't focus on the OTP 2 input I suppose.
There was a problem hiding this comment.
we should auto focus to second box, after first box has 6 digits
There was a problem hiding this comment.
Good point. Will add that.
# Conflicts: # code/lib/api/flow.js
…urity-frontend # Conflicts: # code/lib/api/flow.js
polymorpher
changed the title
|
Everything works - very good job |
This is working in progress as part of client-security branch.