Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/75 less ambiguous wallet names #77

Merged
merged 5 commits into from
Aug 14, 2021

Conversation

haolinj
Copy link
Collaborator

@haolinj haolinj commented Aug 12, 2021

No description provided.

@polymorpher
Copy link
Owner

Looks good, except the address should show the full address as the tooltip when hovered over. I suggest creating a new component for Address, since another change in this version requires the address to be displayed in ETH form when hovered over for more than 1 second.

Actually, let's replace the explorer link with a toggle to the Address component. Toggle it when the user clicks the address, instead of sending them to the explorer. When the toggle is on, show more buttons to the right:

  1. copy (already here)
  2. go to explorer in new window (use the address consistent with the current style)
  3. switch address style (toggle button) between bech32 (one1...) and hex (0x...)

use some sensible icon from antdesign icon collections

@haolinj
Copy link
Collaborator Author

haolinj commented Aug 13, 2021

Looks good, except the address should show the full address as the tooltip when hovered over. I suggest creating a new component for Address, since another change in this version requires the address to be displayed in ETH form when hovered over for more than 1 second.

Actually, let's replace the explorer link with a toggle to the Address component. Toggle it when the user clicks the address, instead of sending them to the explorer. When the toggle is on, show more buttons to the right:

1. copy (already here)

2. go to explorer in new window (use the address consistent with the current style)

3. switch address style (toggle button) between bech32 (one1...) and hex (0x...)

use some sensible icon from antdesign icon collections

Yep, makes sense. I've updated the PR. Please re-review when you have time.

@polymorpher
Copy link
Owner

Looks good. Let's use this everywhere where addresses are displayed.

@polymorpher polymorpher merged commit b94bb2d into master Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants