Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Minimal routing DSL #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

seanphawkins
Copy link

@seanphawkins seanphawkins commented May 17, 2020

I've thrown together a fairly minimal routing DSL that loosely mimics Akka HTTP's syntax. It arbitrarily supports URIs with up to six variable parts.

Any feedback would be appreciated. Happy to have it folded into the baseline, move it to a different project or discard it in favor of something better.

Thanks for the work you have put into uzhttp and the Zio community.

@jeremyrsmith
Copy link
Contributor

I really like this, so thanks so much for the PR.

Let me tell you why I'm not going to merge it right now 😄

There's some new momentum on zio-web (nee zio-http) which I think could subsume this use case. I'd rather it be harder for people to use this library, than have people adopt it and then I abandon it because zio-web covers the use cases. IOW, let's wait until zio-web gains some clarity, and if there's still a niche for a minimal HTTP server, then I'll be all over merging this (it's exactly the kind of thing I'd want to see in a minimal routing API for this library!) In the meantime, I think you'll be OK because you probably embedded this in your project already 😛

@seanphawkins
Copy link
Author

seanphawkins commented May 19, 2020 via email

@frekw
Copy link
Contributor

frekw commented Feb 17, 2021

Just wanted to chime in, I've been using this for Kubernetes health checks and some very trivial HTTP endpoints by just embedding it my project. Works great, and since zio-web is taking a while, as well as having a much larger scope, I'd be in favour of getting this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants