Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: throws response undefined in identifier with falsy condition #782

Merged
merged 3 commits into from Mar 26, 2024

Conversation

johnstonmatt
Copy link
Contributor

@johnstonmatt johnstonmatt commented Mar 22, 2024

Description

  • Template module could fail to resolve correctly if there were undefined prompts in the identifier component of $cndi.get_block(identifier) calls, even if the condition of the call is unmet.

Test Instructions

Code of Conduct

By submitting this Pull Request, you agree to follow our
Code of Conduct

  • I agree to follow this CNDI's Code of Conduct

Notes (Optional)

@johnstonmatt johnstonmatt marked this pull request as ready for review March 26, 2024 08:18
@johnstonmatt johnstonmatt added the bug Something isn't working label Mar 26, 2024
@johnstonmatt johnstonmatt self-assigned this Mar 26, 2024
@johnstonmatt johnstonmatt merged commit 55efe8e into main Mar 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant