Fix selectors in charts for service and hpa #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanjds
approved these changes
Jul 6, 2021
Comment on lines
+53
to
+91
| {{/* | ||
| Nginx labels | ||
| */}} | ||
| {{- define "microengine-webhooks-py.nginx.labels" -}} | ||
| helm.sh/chart: {{ include "microengine-webhooks-py.chart" . }} | ||
| {{ include "microengine-webhooks-py.nginx.selectorLabels" . }} | ||
| {{- if .Chart.AppVersion }} | ||
| app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} | ||
| {{- end }} | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Nginx selector labels | ||
| */}} | ||
| {{- define "microengine-webhooks-py.nginx.selectorLabels" -}} | ||
| app.kubernetes.io/name: {{ include "microengine-webhooks-py.name" . }}-nginx | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Worker labels | ||
| */}} | ||
| {{- define "microengine-webhooks-py.worker.labels" -}} | ||
| helm.sh/chart: {{ include "microengine-webhooks-py.chart" . }} | ||
| {{ include "microengine-webhooks-py.worker.selectorLabels" . }} | ||
| {{- if .Chart.AppVersion }} | ||
| app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} | ||
| {{- end }} | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Worker selector labels | ||
| */}} | ||
| {{- define "microengine-webhooks-py.worker.selectorLabels" -}} | ||
| app.kubernetes.io/name: {{ include "microengine-webhooks-py.name" . }}-worker | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| {{- end }} |
There was a problem hiding this comment.
On Helm charts, it feels specially hard to figure out the correctness of the changes by glancing at the code.
Would be nice to have a diff of the make template somehow on the PR.
If I remember, will try to automate this diffing thing, at least up to a text to be copy-pasted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the hpa targets to point to the correct pods.
Fixes the service selector labels to point to the correct pods.