Ignore classes that inherit non-synthetic toString

[kubukoz]

Given a class that has a toString defined in a parent (which isn't Object), which isn't the toString generated automatically for case classes, we should not define a custom toString for that class.

[carstenlenz]

That would be helpful - We just noticed (after updating) that we 'accidentally' relied on #59 - we use better-tostring together with enumeratum - and the upgrade broke all places where enums where looked up via string (as the encapsulating object is now the prefix in the toString method of the enum case object).
A simple 'dummy' (e.g. override def toString = super.toString) could then help with this in a custom base EnumEntry class - which I had to add now anyway to build a custom entryName without relying on toString.

[mrobakowski]

We have the exact same problem (b2s + enumeratum). I tried fixing this before, but I couldn't find a reliable way to do this other than generating toStrings which at runtime check via reflection if any of the parent classes defined their own toStrings... which needless to say isn't ideal.

Currently, the (scala 2) plugin operates right after the compiler's parser, so we don't have any types or even resolved symbols. I tried moving it somewhere else down the pipeline, but it broke more than it fixed :/

[carstenlenz]

@mrobakowski for enumeratum you could simply define your own base trait to use instead of EntryName couldn't you? defining a entryName method with s.th. like getClass.getSimpleName.<stripOfLastCharIfItIsDollar> at least fixes enumeratums logic.

[mrobakowski]

@carstenlenz yeah, that works (and is in fact better than our current workarounds, so thanks 😄) for enumeratum.

However, I would really like this to just work out of the box. I'll try again to mess around with compiler stages because I think we run after the typer in the scala 3 version, so perhaps there is a way to do this properly in scala 2 as well. Unfortunately, my experience with scala compiler plugins is pretty much limited to just this project, so it may take me a while (if it's possible at all).

[kubukoz]

getClass.getSimpleName.stripSuffix("$") seems to work for now :D but yeah, it'd be best to do this right here in the plugin.