Add Not node in dhall config #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkowalcze
changed the title
pkowalcze
commented
Mar 30, 2021
dhall/core.dhall
Outdated
| , Not = | ||
| λ(matcher : Matcher) → | ||
| λ(M : Type) → | ||
| elem M (λ(RC : MatcherFold M) → RC.Not) |
There was a problem hiding this comment.
This is definitely not right, but I lack the knowledge to work it out. @kubukoz could you take a look?
kubukoz
reviewed
Mar 30, 2021
| @@ -50,6 +50,7 @@ object Matcher { | |||
| final case class PipelineStatus(status: String) extends Matcher | |||
| final case class Many(values: List[Matcher]) extends Matcher | |||
| final case class OneOf(values: List[Matcher]) extends Matcher | |||
| final case class Not(value: Matcher) extends Matcher | |||
There was a problem hiding this comment.
and now I'm realizing this should be underlying because I called it that. @pkowalcze do you wanna rename this one?
There was a problem hiding this comment.
Sure, here's the PR: #201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested in #128