Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pitgull bootstrap cli #264

Merged
merged 26 commits into from
Jun 12, 2021
Merged

Pitgull bootstrap cli #264

merged 26 commits into from
Jun 12, 2021

Conversation

majk-p
Copy link
Member

@majk-p majk-p commented Jun 8, 2021

No description provided.

@majk-p majk-p marked this pull request as draft June 8, 2021 16:58
@majk-p
Copy link
Member Author

majk-p commented Jun 8, 2021

In ci.yml workflow plugin has generated: run: tar cf targets.tar target gitlab/target bootstrap/target core/target project/target while bootstrap/target is empty. I think we need a way to work around this as currently this breaks the pipeline.

@kubukoz any ideas? should we keep bootstrap/target empty in repo as a hack, or perhaps suggest changes to the plugin?

@kubukoz
Copy link
Member

kubukoz commented Jun 8, 2021

@majk-p

@kubukoz any ideas? should we keep bootstrap/target empty in repo as a hack, or perhaps suggest changes to the plugin?

I think both :) do the hack with .gitkeep for now, while we await the change in the plugin

@majk-p
Copy link
Member Author

majk-p commented Jun 9, 2021

@majk-p

@kubukoz any ideas? should we keep bootstrap/target empty in repo as a hack, or perhaps suggest changes to the plugin?

I think both :) do the hack with .gitkeep for now, while we await the change in the plugin

Apparently there's a fix for that in the library. I didn't notice it at the first glance: sbt/sbt-github-actions#60 (comment)

@majk-p majk-p marked this pull request as ready for review June 9, 2021 17:08
@majk-p majk-p changed the title Draft: Pitgull bootstrap cli Pitgull bootstrap cli Jun 9, 2021
build.sbt Outdated Show resolved Hide resolved
build.sbt Show resolved Hide resolved
build.sbt Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated
),
testFrameworks += new TestFramework("weaver.framework.TestFramework"),
publish / skip := true,
Compile / mainClass := Some("org.polyvariant.Main"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this made me realize we should have a sub-package there. org.polyvariant.bootstrap or io.pg.bootstrap for consistency with the rest :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about renaming this one to org.polyvariant.pitgull.bootstrap and creating ticket to repackage io.pg in main application to org.polyvariant.pitgull.app?

Copy link
Member

@kubukoz kubukoz Jun 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convince me why that's better and we can do it :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better because:

  • We can avoid confusion - package name matches the organization name
  • Someone else owns pg.io, and it's registered till 2027
Domain Name: PG.IO
Registry Domain ID: D503300000040413631-LRMS
...
Creation Date: 2003-09-22T14:07:39Z
Registry Expiry Date: 2027-04-30T12:00:00Z

I'd say let's leave the package name unchanged for now, and sort this out in separate PR.

README.md Outdated Show resolved Hide resolved
@majk-p majk-p requested a review from kubukoz June 12, 2021 14:53
@majk-p majk-p merged commit 439e307 into main Jun 12, 2021
@majk-p majk-p deleted the pitgull-bootstrap-cli branch June 12, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants