-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Scala 3 #431
Use Scala 3 #431
Conversation
@majk-p we'll finally be able to reuse some gitlab code in the bootstrap 😅 |
|
||
object ProjectConfigFormatTest extends FunSuite { | ||
|
||
val asJSON = json"""{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated based on a dump from dhall-to-json
private object CirceConfiguration { | ||
implicit val circeConfig: Configuration = Configuration.default.withDiscriminator("@type") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically this changes the format, but this was meant for debugging only anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 few minor things and LGMT
circe-generic-extras being missing is probably the biggest pain point, using a custom solution for now.