Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Scala 3 #431

Merged
merged 7 commits into from
May 21, 2022
Merged

Use Scala 3 #431

merged 7 commits into from
May 21, 2022

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented May 21, 2022

circe-generic-extras being missing is probably the biggest pain point, using a custom solution for now.

@kubukoz
Copy link
Member Author

kubukoz commented May 21, 2022

@majk-p we'll finally be able to reuse some gitlab code in the bootstrap 😅

@kubukoz kubukoz requested a review from majk-p May 21, 2022 17:44

object ProjectConfigFormatTest extends FunSuite {

val asJSON = json"""{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated based on a dump from dhall-to-json

Comment on lines -8 to -10
private object CirceConfiguration {
implicit val circeConfig: Configuration = Configuration.default.withDiscriminator("@type")
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this changes the format, but this was meant for debugging only anyway.

Copy link
Member

@majk-p majk-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 few minor things and LGMT

core/src/main/scala/io/pg/messaging/messaging.scala Outdated Show resolved Hide resolved
gitlab/src/main/scala/io/pg/gitlab/Gitlab.scala Outdated Show resolved Hide resolved
src/main/scala/io/pg/webhook/webhook.scala Outdated Show resolved Hide resolved
@kubukoz kubukoz merged commit c666413 into main May 21, 2022
@kubukoz kubukoz deleted the scala3 branch May 21, 2022 18:49
@kubukoz kubukoz mentioned this pull request Dec 5, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants