Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsoniter-scala #8

Closed
goral09 opened this issue Dec 22, 2020 · 3 comments
Closed

jsoniter-scala #8

goral09 opened this issue Dec 22, 2020 · 3 comments

Comments

@goral09
Copy link

goral09 commented Dec 22, 2020

Have you considered using https://github.com/plokhotnyuk/jsoniter-scala for JSON (de)serialization?
@kubukoz
Copy link
Member

kubukoz commented Dec 22, 2020

I think it's beyond the scope for now, but who's to say whether we'll allow more flexibility in the future :)

If enough people think this is worthwhile, I think there's a fair chance it'll happen.

@jwojnowski
Copy link
Contributor

I'll take a look at how can we restructure the lib to enable a wider choice of JSON (de)serialisation.

jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 10, 2023
@jwojnowski
polyvariant#8 ♻️ Restructure JSON (de)serialisation to enable other i…
81fe976 
…mplementations than Circe.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 10, 2023
@jwojnowski
polyvariant#8 ♻️ Restructure JSON (de)serialisation to enable other i…
9ae798b 
…mplementations than Circe.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 10, 2023
@jwojnowski
polyvariant#8 ♻️ Restructure JSON (de)serialisation to enable other i…
97e5e1d 
…mplementations than Circe.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 10, 2023
@jwojnowski
polyvariant#8 ♻️ Restructure JSON (de)serialisation to enable other i…
17ed2b1 
…mplementations than Circe.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 10, 2023
@jwojnowski
polyvariant#8 ♻️ Restructure JSON (de)serialisation to enable other i…
20cb67a 
…mplementations than Circe.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 10, 2023
@jwojnowski
polyvariant#8 ♻️ Restructure JSON (de)serialisation to enable other i…
6fed331 
…mplementations than Circe.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 10, 2023
@jwojnowski
polyvariant#8 ♻️ Restructure JSON (de)serialisation to enable other i…
c903233 
…mplementations than Circe.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 10, 2023
@jwojnowski
polyvariant#8 ♻️ Restructure JSON (de)serialisation to enable other i…
3fdedd8 
…mplementations than Circe.
@jwojnowski jwojnowski mentioned this issue Feb 10, 2023
Merged
3 tasks
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 10, 2023
@jwojnowski
polyvariant#8 💚 Add new modules to the CI.
8c8000b
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 ♻️ Revert the core module and group JSON-related tests …
3fd6ace 
…in a single trait for simplified implementation per JSON module.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 ♻️ Remove unused EntityDecoder. Replace codec in names …
8115169 
…with json.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 ♻️ Remove JsonInput.sanitize from JsonSupport and move …
9ec9df0 
…it to the main package.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 ♻️ Restructure JSON (de)serialisation to enable other i…
30d83df 
…mplementations than Circe.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 💚 Add new modules to the CI.
55e1b4a
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 ♻️ Revert the core module and group JSON-related tests …
6d2a0e5 
…in a single trait for simplified implementation per JSON module.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 ♻️ Remove unused EntityDecoder. Replace codec in names …
36fc41f 
…with json.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 ♻️ Remove JsonInput.sanitize from JsonSupport and move …
c032449 
…it to the main package.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 🎨 Optimise imports and reformat a few files.
6fd4911
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 ♻️ Remove JsonInput.sanitize from JsonSupport and move …
c5d832a 
…it to the main package.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 🎨 Optimise imports and reformat a few files.
56eeda6
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 ♻️ Remove unused EntityDecoder. Replace codec in names …
33caea1 
…with json.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 ♻️ Remove JsonInput.sanitize from JsonSupport and move …
2bbfed9 
…it to the main package.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 🎨 Optimise imports and reformat a few files.
1324c62
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 ♻️ Remove unused EntityDecoder. Replace codec in names …
82d2ccb 
…with json.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 ♻️ Remove JsonInput.sanitize from JsonSupport and move …
e3cf811 
…it to the main package.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 🎨 Optimise imports and reformat a few files.
0726821
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 🎨 Optimise imports and reformat a few files.
a2a145f
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 🎨 Optimise imports and reformat a few files.
c1cd2f8
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 14, 2023
@jwojnowski
polyvariant#8 🎨 Optimise imports and reformat a few files.
c9c362b
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 17, 2023
@jwojnowski
polyvariant#8 📝 Modify docs to reflect changes in JSON deserialisatio…
d873557 
…n support.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 20, 2023
@jwojnowski
polyvariant#8 📝 Add backwards compatibility TL;DR regarding circe mod…
88d5a29 
…ule to the changelog 👌.
jwojnowski added a commit to jwojnowski/sttp-oauth2 that referenced this issue Feb 23, 2023
@jwojnowski
polyvariant#8 ✨ Add jsoniter-scala module.
69c6967
majk-p pushed a commit that referenced this issue Feb 28, 2023
@jwojnowski
#8 ♻️ Restructure JSON deserialisation to enable other implementation…
76f7aa2 
…s than Circe (#351)

* #8 ♻️ Restructure JSON (de)serialisation to enable other implementations than Circe.

* #8 💚 Add new modules to the CI.

* #8 ♻️ Revert the core module and group JSON-related tests in a single trait for simplified implementation per JSON module.

* #8 ♻️ Remove unused EntityDecoder. Replace codec in names with json.

* #8 ♻️ Remove JsonInput.sanitize from JsonSupport and move it to the main package.

* #8 🎨 Optimise imports and reformat a few files.

* #8 📝 Modify docs to reflect changes in JSON deserialisation support.

* #8 📝 Add backwards compatibility TL;DR regarding circe module to the changelog 👌.

* ♻️ Make `EncodedJson` final.

* #8 ✨ Add jsoniter-scala module.

* 💚 Fix CI.

* ⬆️ Bump sbt-scalajs.

* ⬆️ Bump scala 3 version.

* 🔧 Tweak deprecation warning configuration for jsoniter modules.

Macro-generated code uses deprecated methods:
```
.../com/github/plokhotnyuk/jsoniter_scala/macros/JsonCodecMaker.scala: method isEmpty in class IterableOnceExtensionMethods is deprecated since 2.13.0: Use .iterator.isEmpty instead
```

* ♻️ Move OAuth2Error creation to common to avoid duplication in JSON implementations.
@majk-p
Copy link
Member

majk-p commented Feb 28, 2023

Implemented in #351

@majk-p majk-p closed this as completed Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kubukoz @goral09 @majk-p @jwojnowski