Android (Kotlin) app template #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,7 +17,7 @@ Commands: | |||
| wasm [options] <language> <name> Create a Polywrap wasm wrapper. langs: | |||
| assemblyscript, rust, golang, interface | |||
| app [options] <language> <name> Create a Polywrap application. langs: | |||
| typescript | |||
| typescript, android | |||
There was a problem hiding this comment.
Can there be vanilla kotlin or something? Just wondering since the template here is android specific
There was a problem hiding this comment.
We could create another template that is not Android, sure. We have always treated Kotlin as a means of targeting android users, so I think having an Android template makes more sense.
Merged
…plate # Conflicts: # packages/cli/src/__tests__/e2e/p1/create.spec.ts # packages/cli/src/commands/create.ts
…kotlin-template # Conflicts: # packages/templates/app/android/polywrap.graphql
dOrgJelli
previously approved these changes
Sep 1, 2023
dOrgJelli
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Android app template using the Kotlin app bindings.
Depends on:
#1868
polywrap/wrap-abi-bindgen#53
Ethereum wrapper invocation is not yet working due to incompatibility in Rust wrapscan uri resolver: