Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small revisions and fixes For Wasm templates #1924

Open
wants to merge 8 commits into
base: origin-dev
Choose a base branch
from

Conversation

krisbitney
Copy link
Contributor

@krisbitney krisbitney commented Oct 24, 2023

This PR updates Wasm templates in the following ways:

  • makes the templates more consistent with each other
  • removes workflows (polywrap.test.yaml, cue file, and yarn scripts)
  • removes polywrap.deploy.yaml files
  • fixes bugs in the rust template
  • fixes bugs in the TS template
  • updated to latest app codegen in tests

The TS template doesn't build due to #1923

The Go template doesn't build due to #1925

For reasoning on why we would remove workflows: https://discord.com/channels/796821176743362611/1166324052164628560

I removed the deploy manifests because the default behavior of npx polywrap deploy is IPFS deployment. Since we are encouraging use of IPFS and Wrapscan URIs, most users will not need to customize deployment. Our documentation will provide ample guidance for users who do wish to use a deploy manifest.

@krisbitney krisbitney marked this pull request as ready for review October 24, 2023 12:51
@krisbitney krisbitney changed the title Small revisions to wasm templates Small revisions and fixes For Wasm templates Oct 24, 2023
@dOrgJelli
Copy link
Member

I'm good with merging this, but the CI is still red for the templates, looks like some of them aren't properly building:
https://github.com/polywrap/cli/actions/runs/6706112620/job/18221943589?pr=1924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants