Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug modification residue #2802

Closed
ValWood opened this issue Jan 30, 2024 · 8 comments
Closed

bug modification residue #2802

ValWood opened this issue Jan 30, 2024 · 8 comments

Comments

@ValWood
Copy link
Member

ValWood commented Jan 30, 2024

I tested with "phosphorylated residue"
cid12 S26 (was told "no such residue at this position), so maybe I had not used this yet!

@kimrutherford kimrutherford self-assigned this Jan 31, 2024
@kimrutherford
Copy link
Member

Could you double check that? I just tried and it was OK:

image

@ValWood
Copy link
Member Author

ValWood commented Jan 31, 2024

Now, I cannot make the residue accept at all?

I press OK and it stays like this:
Screenshot 2024-01-31 at 11 29 17

kimrutherford added a commit that referenced this issue Jan 31, 2024
Seems like it needs more work:
#2802 (comment)

This reverts commit d618789.
@ValWood
Copy link
Member Author

ValWood commented Feb 6, 2024

I tried again, it happens when there is an existing annotation (usually you see a message that the annotation already exists .

@kimrutherford
Copy link
Member

Note to self: the bug is in the long workflow.

We've talked about removing the long workflow so I thought about holding off on fixing this bug. But it turned out to be a quick to fix. It should be working now in the main Canto.

Could you give it a test when you get a chance?

@pombase pombase deleted a comment from kimrutherford Feb 29, 2024
@pombase pombase deleted a comment from kimrutherford Feb 29, 2024
@ValWood
Copy link
Member Author

ValWood commented Feb 29, 2024

It works too well ;) I could create 2 annotations:

Screenshot 2024-02-29 at 07 54 11

@pombase pombase deleted a comment from kimrutherford Feb 29, 2024
@pombase pombase deleted a comment from kimrutherford Feb 29, 2024
@kimrutherford
Copy link
Member

Thanks for testing.

@ValWood
Copy link
Member Author

ValWood commented Feb 29, 2024

SOrry my comment was too cryptic. I was allowed to create 2 identical annotations. The error should be that the annotation already exists ;)

@kimrutherford
Copy link
Member

OK, I've made a separate issue about that: #2806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants