-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display of promoter info on gene pages, and genotype pages #2161
Comments
Part of this is implemented already, by accident. Genotypes with and without promoters are already combined on the same page. For example
But there is only one genotype page: The promoter is getting lost when the the genotypes are merged but the annotation is kept. One of the genotype comments is getting lost too. Maybe the comments need to be included in the annotation table like we do for the background and we plan to do with the promoters? |
Some of the genotype comments are really long, and I think many of them need to be migrated to allele comments. |
- don't show the allele name if there's only one allele - don't add the text "promoter:" when it's not needed Refs #2161
I think the label is a bit confusing because this is a manipulated s. pombe promoter. CC @PCarme |
Linking to the gene to which the promoter is endogenously associated doesn't seem very useful to me. Aside from the expression data, most of the information about this gene are irrelevant to the case of a promoter swap anyway... |
I don't follow that. What do you mean by control the contents? We could just have a "Promoter swap (S. pombe)" checkbox if that's all that's needed. We could remove the ability for people to select the pombe gene if that detail isn't necessary. |
So remove the text "exogenous promoter"? |
I can't remember the original rationale. We want the gene, but there isn't a big reason to separate exogenous and endogenous (IMHO). We could just always have a single field and make them type the promoter. I think it is better to discuss this on a call. |
Summary
|
I'll remove that code when I change the loading code: |
I changed the web site code to handle having just one sort of promoter to display. I'll push the changes at the weekend once I upgrade the Canto database to the new schema (pombase/canto#2823). Branch: pombase-chado-issue-567-go-ev-code-graph |
We now use just "promoter_gene". Refs pombase/pombase-chado#1163 Refs pombase/canto#2823 Refs #2161
We now use just "promoter_gene". Refs pombase/pombase-chado#1163 Refs pombase/canto#2823 Refs #2161
That's done now. I'll check the website on Sunday. |
All seems OK except that I found a case where the promoters aren't appearing in the annotation table on the gene page. For And on the term page: But they are missing from the gene page: |
Fixed. I'll close this because it seems mostly done and there are a lot of comments. |
The were missing from underneath the genotype display name and background in the annotation table. Refs #2161
Collect all genotypes which differ only by promoter onto the same genotype page
(this is analogous to background)
Rationale:
Most users will want to see all of the associated phenotypes.
How it looks on
Gene Page
Term page
Publication page
Genotype page
All alleles of a gene
Allele page
Also need to think about multi locus
The text was updated successfully, but these errors were encountered: