Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detail view sensitive to annotation problem #410

Closed
ValWood opened this issue Jun 25, 2017 · 12 comments
Closed

detail view sensitive to annotation problem #410

ValWood opened this issue Jun 25, 2017 · 12 comments

Comments

@ValWood
Copy link
Member

ValWood commented Jun 25, 2017

I came across this yesterday.
Not sure how to describe without a lot of words!

But this pic shows a supposed "details view"

2 issues:

  1. octanoyltransferase is collapsed as in detail view (i.e evidence is not showing)
  2. With field is missing for ISS (curation seems OK with=UniProt:A6NK58; )

This is lip2, I didn't see similar on any other page yet?

@ValWood
Copy link
Member Author

ValWood commented Jun 25, 2017

show details bug

@mah11
Copy link
Member

mah11 commented Jun 26, 2017

problem is likely that the with entry should be UniProtKB:A6NK58 (i.e. prefix not just "UniProt"); I've just fixed it

although maybe Kim could also do something to make a problem with one annotation not affect the display of other annotations

@ValWood
Copy link
Member Author

ValWood commented Jul 12, 2017

Is this already on the chado tracker in some guise?
Maybe the issue is just to cosistently check the IDs...or is there a differnet problem.

@mah11 could you decide if a ticket is required and close this one?

@ValWood ValWood assigned mah11 and unassigned kimrutherford Jul 12, 2017
@ValWood ValWood removed this from the public-release-of-v2 milestone Jul 12, 2017
@kimrutherford
Copy link
Member

It looks OK to me - you have clicked to show the details of the first annotation, but not the second (one has "-" one has "+")

@mah11 mah11 changed the title small bug in GO MF collapsing detail view sensitive to annotation problem Jul 13, 2017
@mah11
Copy link
Member

mah11 commented Jul 13, 2017

The original problem is that we were seeing the display in the screenshot when we clicked the "show details" link for the whole MF section (I think due to an annotation problem that has since been fixed), not just the + for one annotation.

There is an outstanding website task to ensure that a problem with one annotation doesn't bork the display of other annotations in the same section. This is the ticket for that.

I've added a comment to an existing Chado ticket to get similar annotation problems reported - pombase/pombase-chado#614

@ValWood
Copy link
Member Author

ValWood commented Jul 13, 2017

so I can close this on...

@ValWood ValWood closed this as completed Jul 13, 2017
@mah11
Copy link
Member

mah11 commented Jul 13, 2017

I would not close this, unless Kim has done something to ensure that one off-kilter annotation doesn't affect the display of good ones.

@mah11 mah11 reopened this Jul 13, 2017
@kimrutherford
Copy link
Member

The original problem is that we were seeing the display in the screenshot when we clicked the
"show details" link for the whole MF section

I can't reproduce that. "Show details ..." and "Show summary ..." and the plus/minus buttons work fine for me for the MF section on the lip2 page.

Val, did you see that on preview or on http://pombase2.bioinformatics.nz? Although they should be the same.

@mah11
Copy link
Member

mah11 commented Jul 14, 2017

Yeah, it wouldn't be reproducible for this gene page now, because we've fixed the annotation that was causing the problem.

If you want, I could un-fix it for you to see the effect.

@ValWood
Copy link
Member Author

ValWood commented Jul 14, 2017

Maybe this is enough to fix similar problems at source?
pombase/pombase-chado#614

@ValWood
Copy link
Member Author

ValWood commented Aug 14, 2017

Can I close this one since there is a ticket to add a check to chado?

@kimrutherford
Copy link
Member

Yep, I think so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants