Skip to content

Commit

Permalink
Fix Custom Select Arrow Box Height Issue
Browse files Browse the repository at this point in the history
It seems that the following `30px` (which makes the little box with the dropdown arrow _taller_ than the rest of the dropdown) might be a mistake (perhaps missed during a previous change?):
```css
/* Correct FF custom dropdown height */
@-moz-document url-prefix() {
  form.custom div.custom.dropdown a.selector { height: 30px; }
}
.lt-ie9 form.custom div.custom.dropdown a.selector { height: 30px; }
```
https://github.com/zurb/foundation/blob/master/scss/foundation/common/_forms.scss#L115

It looks like it should be `28px` as it is earlier in the code (eg, https://github.com/zurb/foundation/blob/master/scss/foundation/common/_forms.scss#L72 and following lines)?

This Pull Request changes fixes this.
  • Loading branch information
EnigmaSolved committed Nov 27, 2012
1 parent c5422e2 commit 6283985
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scss/foundation/common/_forms.scss
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,6 @@

/* Correct FF custom dropdown height */
@-moz-document url-prefix() {
form.custom div.custom.dropdown a.selector { height: 30px; }
form.custom div.custom.dropdown a.selector { height: 28px; }
}
.lt-ie9 form.custom div.custom.dropdown a.selector { height: 30px; }
.lt-ie9 form.custom div.custom.dropdown a.selector { height: 28px; }

0 comments on commit 6283985

Please sign in to comment.