Fixed writeValues not handling new lines

pombredanne · May 19, 2011 · 65c2d14 · 65c2d14
1 parent 9c96976
commit 65c2d14
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/node.io/io.js b/lib/node.io/io.js
@@ -569,12 +569,15 @@ Job.prototype.writeValues = function(values, delim, quote, quote_escape) {
     quote_escape = quote_escape || '"';
 
     if (values instanceof Array) {
-        var quoted_values = [], value, quote_reg = new RegExp('[' + quote + ']', 'g');
+        var quoted_values = [], value,
+            quote_reg = new RegExp('[' + quote + ']', 'g'),
+            requires_quotes = new RegExp('[' + delim + '\r\n]');
+
         for (var i = 0, l = values.length; i < l; i++) {
             value = values[i] == null ? '' : '' + values[i];
             if (value && value.indexOf(quote) > -1) {
                 value = quote + value.replace(quote_reg, quote_escape + quote) + quote;
-            } else if (value == '' || value.indexOf(delim) > -1) {
+            } else if (value == '' || requires_quotes.test(value)) {
                 value = quote + value + quote;
             }
             quoted_values.push(value);

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 { "name"          : "node.io",
   "description"   : "A distributed data scraping and processing framework",
-  "version"       : "0.2.9-2",
+  "version"       : "0.2.9-3",
   "homepage"      : "http://github.com/chriso/node.io",
   "keywords"      : ["data","mapreduce","map","reduce","scraping","html","parsing","parse","scrape","process","processing","data"],
   "author"        : "Chris O'Hara <cohara87@gmail.com>",