update redirects to address some 404s from GSC #1525
Conversation
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This PR is related to https://github.com/pomerium/internal/issues/1841 |
|
@kenjenkins the
|
410 Gone isn't a redirect. It's used to signal that a page has been intentionally and permanently removed. |
| /docs/reference/policy/allowed-users https://0-14-0.docs.pomerium.com/reference | ||
| /docs/reference/policy/allowed-domains https://0-14-0.docs.pomerium.com/reference/#allowed-domains | ||
| /docs/reference/policy/allowed-idp-claims https://0-14-0.docs.pomerium.com/reference/#allowed-idp-claims | ||
| /docs/reference/policy/allowed-groups https://0-14-0.docs.pomerium.com/reference/#allowed-groups |
There was a problem hiding this comment.
I'm not sure whether it's worth adding this one (v0.14 was a long time ago), but I thought it might make sense to be consistent with the others. (And if we have them, I figured it made sense to add anchor tags so they link to the relevant section heading.)
There was a problem hiding this comment.
I agree for the sake of consistency, too. It can't hurt.
| /docs/reference/policy/policy https://0-14-0.docs.pomerium.com/reference | ||
|
|
||
| # Link from v23 to v22 | ||
| /docs/reference/routes/headers#set-authorization-header https://0-22-0.docs.pomerium.com/reference/routes/headers#set-authorization-header |
There was a problem hiding this comment.
I think this redirect will never trigger, because of the #set-authorization-header fragment on the source URL. (The fragment isn't part of the request sent to the server, so we can't issue a redirect based on it.) I figured we should just remove this line.
There was a problem hiding this comment.
Right, that makes sense. If that's the behavior of the request, then this redirect is pointless to keep.
|
@kenjenkins I'd like to resolve this PR today if possible. I think this addresses all the important 404ing links for now. |
* update redirects to address some 404s from GSC * fixes links in spreadsheet up to line 119 * adds 410 status, fixes links * remove some extra blank lines --------- Co-authored-by: zachary painter <60552605+ZPain8464@users.noreply.github.com>
update redirects to address some 404s from GSC (#1525) * update redirects to address some 404s from GSC * fixes links in spreadsheet up to line 119 * adds 410 status, fixes links * remove some extra blank lines --------- Co-authored-by: Kenneth Jenkins <51246568+kenjenkins@users.noreply.github.com> Co-authored-by: zachary painter <60552605+ZPain8464@users.noreply.github.com>
We found a few reference setting 404s from the Google Search Console report. I don't think we have any logs from Netlify (which might be able to help us infer whether any real users are hitting these), but I thought it would make sense to add redirects for these.
Related issue: