Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickstart: remove optionals settings for certificates, and cookie secrets #161

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

ZPain8464
Copy link
Contributor

@ZPain8464 ZPain8464 commented Nov 14, 2022

Changes

These changes remove the optional settings for certificates, mounting wild-card certs with docker, secrets, and provides workarounds for when the user is presented with a warning for self-signed certificates.

Related issues

Closes #141 (as dupe)
Closes pomerium/pomerium#3737

@ZPain8464 ZPain8464 requested a review from a team as a code owner November 14, 2022 23:35
@ZPain8464 ZPain8464 requested review from desimone and removed request for a team November 14, 2022 23:35
@netlify
Copy link

netlify bot commented Nov 14, 2022

Deploy Preview for pomerium-docs ready!

Name Link
🔨 Latest commit d45b0cc
🔍 Latest deploy log https://app.netlify.com/sites/pomerium-docs/deploys/637d156c4bc7de000937b64d
😎 Deploy Preview https://deploy-preview-161--pomerium-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

description: This guide covers how to use Pomerium to authenticate and authorize users of HedgeDoc.
---

# HedgeDoc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this in #141

5. After IdP establishes user's identity, Pomerium checks permissions against the secured app
6. User can make authorized requests in the secured app

![Pomerium IAP flow](img/pom-auth-flow.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![Pomerium IAP flow](img/pom-auth-flow.png)
![Pomerium IAP flow](img/pom-auth-flow.png)

For images, to keep organization easy we should subdir the docs. e.g. img/hedgedoc/pom-auth-flow.png


Your browser will redirect you to the route defined in your policy:

![user details page](./img/user-details-page.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up! There are tools like https://shottr.cc/ that make blurring out / calling out in screenshots much cleaner.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed Shottr, WAY cleaner. I'm updating the image.

@ZPain8464
Copy link
Contributor Author

@desimone and @calebdoxsey apologies on the confusion with the HedgeDoc guide and the PoC/Quickstart update – I'll create feature branches for updates going forward.

I've added cleaner images to both docs and created a HedgeDoc subdir for images. Please let me know if anything else needs updating and I'll be happy to jump on it!

@calebdoxsey
Copy link
Contributor

Quickstart LGTM

@desimone desimone self-requested a review November 16, 2022 17:22
@desimone desimone changed the title Zpain8464 poc update quickstart: remove optionals settings for certificates, and cookie secrets Nov 16, 2022

![currently logged in user](./img/logged-in-as.png)
![hsts error](./img/hsts-error.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![hsts error](./img/hsts-error.png)
![self-signed warning](./img/hsts-error.png)


You can also navigate to the special pomerium endpoint `verify.localhost.pomerium.io/.pomerium/` to see your current user details.
### Handle HSTS Errors
When navigating to the `https://verify.localhost.pomerium.io` route defined in your policy, you may encouter the following HSTS error:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When navigating to the `https://verify.localhost.pomerium.io` route defined in your policy, you may encouter the following HSTS error:
When navigating to the `https://verify.localhost.pomerium.io` route defined in your policy, you may encounter the following self-signed certificate warning:


You can also navigate to the special pomerium endpoint `verify.localhost.pomerium.io/.pomerium/` to see your current user details.
### Handle HSTS Errors
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Handle HSTS Errors
### Handle Self-Signed Certificate Warning

Copy link
Collaborator

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of unrelated changes. Looks like you branched off an old main, then did a soft reset?

@ZPain8464
Copy link
Contributor Author

@desimone hopefully this is the final push needed to get this up to date. Requesting review.

Copy link
Collaborator

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@ZPain8464 ZPain8464 merged commit 589140c into pomerium:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto generate wildcard certificates to make PoC / Quickstart easier
3 participants