support default certificate #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdoxsey
approved these changes
Feb 22, 2022
6 tasks
6 tasks
This was referenced Mar 10, 2022
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently it is not possible to share a wildcard certificate between the Ingresses in different namespaces.
There is a cert-manager recommended approach to handle
such situation using a default certificate assigned to the entire IngressClass, that should be
used in case the
Ingress.Spec.TLSsection does not specify thesecret.This PR adds an
ingress.pomerium.io/default-cert-secretthat should be a namespace/secret_name format,referencing a TLS certificate secret.
Also it splits controller code into separate dependencies / reconciliation source code files, and adds an ingress_class.go handling code.
Related issues
Implements #144
Checklist
improvement/bug/ etc)