session: add unit tests for gRPC wrapper methods (#4713)

pomerium · Nov 9, 2023 · 277b172 · 277b172
1 parent 58067fb
commit 277b172
Showing 1 changed file with 159 additions and 0 deletions.
diff --git a/pkg/grpc/session/session_test.go b/pkg/grpc/session/session_test.go
@@ -1,13 +1,172 @@
 package session
 
 import (
+	context "context"
 	"testing"
 	"time"
 
+	"github.com/golang/mock/gomock"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"google.golang.org/grpc"
+	"google.golang.org/grpc/codes"
+	"google.golang.org/grpc/status"
+	"google.golang.org/protobuf/types/known/fieldmaskpb"
 	"google.golang.org/protobuf/types/known/timestamppb"
+
+	"github.com/pomerium/pomerium/internal/testutil"
+	"github.com/pomerium/pomerium/pkg/grpc/databroker"
+	"github.com/pomerium/pomerium/pkg/grpc/databroker/mock_databroker"
+	"github.com/pomerium/pomerium/pkg/protoutil"
 )
 
+func TestDelete(t *testing.T) {
+	t.Parallel()
+
+	ctrl := gomock.NewController(t)
+	client := mock_databroker.NewMockDataBrokerServiceClient(ctrl)
+
+	ctx := context.Background()
+	rpcErr := status.Error(codes.Unavailable, "dummy error for testing")
+
+	client.EXPECT().Put(ctx, gomock.Any(), []grpc.CallOption{}).DoAndReturn(
+		func(_ context.Context, r *databroker.PutRequest, _ ...grpc.CallOption) (*databroker.PutResponse, error) {
+			require.Len(t, r.Records, 1)
+			record := r.GetRecord()
+			assert.Equal(t, "type.googleapis.com/session.Session", record.Type)
+			assert.Equal(t, "session-id", record.Id)
+			testutil.AssertProtoEqual(t, protoutil.NewAny(&Session{}), record.Data)
+			now := time.Now()
+			assert.WithinRange(t, record.DeletedAt.AsTime(), now.Add(-time.Minute), now)
+			return nil, rpcErr
+		})
+
+	err := Delete(ctx, client, "session-id")
+	assert.Same(t, rpcErr, err)
+}
+
+func TestGet(t *testing.T) {
+	t.Parallel()
+
+	ctrl := gomock.NewController(t)
+	client := mock_databroker.NewMockDataBrokerServiceClient(ctrl)
+
+	ctx := context.Background()
+
+	t.Run("ok", func(t *testing.T) {
+		t.Parallel()
+
+		session := &Session{
+			Id:     "session-id",
+			UserId: "user-id",
+		}
+		client.EXPECT().Get(ctx, gomock.Any(), []grpc.CallOption{}).DoAndReturn(
+			func(_ context.Context, r *databroker.GetRequest, _ ...grpc.CallOption) (*databroker.GetResponse, error) {
+				assert.Equal(t, "type.googleapis.com/session.Session", r.Type)
+				assert.Equal(t, "session-id", r.Id)
+				return &databroker.GetResponse{Record: &databroker.Record{
+					Data: protoutil.NewAny(session),
+				}}, nil
+			})
+		s, err := Get(ctx, client, "session-id")
+		assert.NoError(t, err)
+		testutil.AssertProtoEqual(t, session, s)
+	})
+
+	t.Run("rpc error", func(t *testing.T) {
+		t.Parallel()
+
+		rpcErr := status.Error(codes.Unavailable, "dummy error for testing")
+		client.EXPECT().Get(ctx, gomock.Any(), []grpc.CallOption{}).DoAndReturn(
+			func(_ context.Context, r *databroker.GetRequest, _ ...grpc.CallOption) (*databroker.GetResponse, error) {
+				assert.Equal(t, "type.googleapis.com/session.Session", r.Type)
+				assert.Equal(t, "session-id", r.Id)
+				return nil, rpcErr
+			})
+		s, err := Get(ctx, client, "session-id")
+		assert.Nil(t, s)
+		assert.Same(t, rpcErr, err)
+	})
+
+	t.Run("unmarshal error", func(t *testing.T) {
+		t.Parallel()
+
+		client.EXPECT().Get(ctx, gomock.Any(), []grpc.CallOption{}).DoAndReturn(
+			func(_ context.Context, r *databroker.GetRequest, _ ...grpc.CallOption) (*databroker.GetResponse, error) {
+				assert.Equal(t, "type.googleapis.com/session.Session", r.Type)
+				assert.Equal(t, "session-id", r.Id)
+				return &databroker.GetResponse{}, nil // no record
+			})
+		s, err := Get(ctx, client, "session-id")
+		assert.Nil(t, s)
+		assert.ErrorContains(t, err, "error unmarshaling session from databroker")
+	})
+}
+
+func TestPut(t *testing.T) {
+	t.Parallel()
+
+	ctrl := gomock.NewController(t)
+	client := mock_databroker.NewMockDataBrokerServiceClient(ctrl)
+
+	ctx := context.Background()
+
+	dummyPutResponse := &databroker.PutResponse{}
+	rpcErr := status.Error(codes.Unavailable, "dummy error for testing")
+
+	session := &Session{
+		Id:     "session-id",
+		UserId: "user-id",
+	}
+
+	client.EXPECT().Put(ctx, gomock.Any(), []grpc.CallOption{}).DoAndReturn(
+		func(_ context.Context, r *databroker.PutRequest, _ ...grpc.CallOption) (*databroker.PutResponse, error) {
+			require.Len(t, r.Records, 1)
+			record := r.GetRecord()
+			assert.Equal(t, "type.googleapis.com/session.Session", record.Type)
+			assert.Equal(t, "session-id", record.Id)
+			testutil.AssertProtoEqual(t, protoutil.NewAny(session), record.Data)
+			return dummyPutResponse, rpcErr
+		})
+
+	r, err := Put(ctx, client, session)
+	assert.Same(t, dummyPutResponse, r)
+	assert.Same(t, rpcErr, err)
+}
+
+func TestPatch(t *testing.T) {
+	t.Parallel()
+
+	ctrl := gomock.NewController(t)
+	client := mock_databroker.NewMockDataBrokerServiceClient(ctrl)
+
+	ctx := context.Background()
+
+	dummyFieldMask := &fieldmaskpb.FieldMask{}
+	dummyPatchResponse := &databroker.PatchResponse{}
+	rpcErr := status.Error(codes.Unavailable, "dummy error for testing")
+
+	session := &Session{
+		Id:     "session-id",
+		UserId: "user-id",
+	}
+
+	client.EXPECT().Patch(ctx, gomock.Any(), []grpc.CallOption{}).DoAndReturn(
+		func(_ context.Context, r *databroker.PatchRequest, _ ...grpc.CallOption) (*databroker.PatchResponse, error) {
+			require.Len(t, r.Records, 1)
+			record := r.Records[0]
+			assert.Equal(t, "type.googleapis.com/session.Session", record.Type)
+			assert.Equal(t, "session-id", record.Id)
+			testutil.AssertProtoEqual(t, protoutil.NewAny(session), record.Data)
+			assert.Same(t, dummyFieldMask, r.FieldMask)
+			return dummyPatchResponse, rpcErr
+		})
+
+	r, err := Patch(ctx, client, session, dummyFieldMask)
+	assert.Same(t, dummyPatchResponse, r)
+	assert.Same(t, rpcErr, err)
+}
+
 func TestSession_Validate(t *testing.T) {
 	t.Parallel()