Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: wrap global mux with standard middleware #116

Closed
desimone opened this issue May 14, 2019 · 1 comment
Closed

all: wrap global mux with standard middleware #116

desimone opened this issue May 14, 2019 · 1 comment
Milestone

Comments

@desimone
Copy link
Contributor

Describe the bug

Several middleware apply to all services and should wrap the global mux. Additionally, non-routed URLs, or services without handlers (authenticate) will bypass middleware causing unexpected behavior like missing CSP headers or missed health-checks.

Expected behavior

The global http mux should be wrapped with a standard set of middleware. Such as:

  • healthcheck
  • referrer
  • request id
  • ip
  • fwd_ip
  • etc

Additional context

@desimone
Copy link
Contributor Author

Closed by #117

@desimone desimone added this to the v0.0.5 milestone May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant