cmd/pomerium: wrap global mux with standard middleware #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desimone
changed the title
desimone
changed the title
desimone
changed the title
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=========================================
+ Coverage 81.35% 82.16% +0.8%
=========================================
Files 32 32
Lines 1888 1861 -27
=========================================
- Hits 1536 1529 -7
+ Misses 280 262 -18
+ Partials 72 70 -2 |
desimone
force-pushed
the
feature/add-global-middleware
branch
from
b5129dd
to
6016a94
Compare
desimone
changed the title
desimone
force-pushed
the
feature/add-global-middleware
branch
from
6016a94
to
f357397
Compare
yegle
reviewed
May 15, 2019
| "X-Frame-Options": "SAMEORIGIN", | ||
| "X-XSS-Protection": "1; mode=block", | ||
| "Strict-Transport-Security": "max-age=31536000; includeSubDomains; preload", | ||
| "Content-Security-Policy": "default-src 'none'; style-src 'self' 'sha256-pSTVzZsFAqd2U3QYu+BoBDtuJWaPM/+qMy/dBRrhb5Y='; img-src 'self';", |
There was a problem hiding this comment.
Looks like this Content-Security-Policy header is breaking loading javascripts:
Refused to load the script '<URL>' because it violates the following Content Security Policy directive: "default-src 'none'". Note that 'script-src-elem' was not explicitly set, so 'default-src' is used as a fallback.
XXX.apkay.com/:83 Refused to apply inline style because it violates the following Content Security Policy directive: "style-src 'self' 'sha256-pSTVzZsFAqd2U3QYu+BoBDtuJWaPM/+qMy/dBRrhb5Y='". Either the 'unsafe-inline' keyword, a hash ('sha256-wycEadbqyap1lzI8fe5whjcPll4StPOU2pDRk+cjffU='), or a nonce ('nonce-...') is required to enable inline execution.
There was a problem hiding this comment.
Thanks @yegle . The CSP/Referrer-Policy should only apply to authenticate service's http handlers. Good catch. Fix incoming.
This was referenced May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes abstract the shared middleware to the global serve mux. Headers, request id, loggers, and health checks (ping) middleware are now applied on all routes including 4xx and 5xx responses.
See
Checklist:
/cc @yegle