New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tls_server_name
option to policy file.
#297
Conversation
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
=======================================
- Coverage 86.1% 86% -0.2%
=======================================
Files 46 46
Lines 2734 2738 +4
=======================================
Hits 2355 2355
- Misses 299 302 +3
- Partials 80 81 +1
|
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
=======================================
- Coverage 86.1% 86% -0.2%
=======================================
Files 46 46
Lines 2734 2738 +4
=======================================
Hits 2355 2355
- Misses 299 302 +3
- Partials 80 81 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Do you mind squashing your commits and moving the changelog entry?
Thanks @yegle
5b241c7
to
50b0abc
Compare
50b0abc
to
27a3870
Compare
This is ready to merge now. |
Thanks! |
config: add tls_server_name option
This option is useful when your backend is an HTTPS server, has a valid certificate, but you want to communicate with it using an internal hostname (e.g. Docker container name), or even IP addresses.
Checklist: