Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tls_server_name option to policy file. #297

Merged
merged 1 commit into from Sep 7, 2019

Conversation

yegle
Copy link
Contributor

@yegle yegle commented Sep 6, 2019

config: add tls_server_name option

This option is useful when your backend is an HTTPS server, has a valid certificate, but you want to communicate with it using an internal hostname (e.g. Docker container name), or even IP addresses.

Checklist:

  • updated docs
  • unit tests added
  • related issues referenced
  • updated CHANGELOG.md
  • ready for review

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #297 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #297     +/-   ##
=======================================
- Coverage    86.1%    86%   -0.2%     
=======================================
  Files          46     46             
  Lines        2734   2738      +4     
=======================================
  Hits         2355   2355             
- Misses        299    302      +3     
- Partials       80     81      +1
Impacted Files Coverage Δ
internal/config/policy.go 100% <ø> (ø) ⬆️
proxy/proxy.go 90.7% <100%> (-2.7%) ⬇️

@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #297 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master   #297     +/-   ##
=======================================
- Coverage    86.1%    86%   -0.2%     
=======================================
  Files          46     46             
  Lines        2734   2738      +4     
=======================================
  Hits         2355   2355             
- Misses        299    302      +3     
- Partials       80     81      +1
Impacted Files Coverage Δ
internal/config/policy.go 100% <ø> (ø) ⬆️
proxy/proxy.go 90.7% <0%> (-2.7%) ⬇️

Copy link
Contributor

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Do you mind squashing your commits and moving the changelog entry?

Thanks @yegle

docs/docs/reference/reference.md Show resolved Hide resolved
docs/docs/CHANGELOG.md Outdated Show resolved Hide resolved
@yegle yegle force-pushed the tls_server_name branch 2 times, most recently from 5b241c7 to 50b0abc Compare September 7, 2019 04:07
@yegle
Copy link
Contributor Author

yegle commented Sep 7, 2019

This is ready to merge now.

@desimone desimone merged commit 1a46cd7 into pomerium:master Sep 7, 2019
@desimone
Copy link
Contributor

desimone commented Sep 7, 2019

Thanks!

@yegle yegle deleted the tls_server_name branch September 8, 2019 01:29
@desimone desimone added this to the v0.4.0 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants