Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add nginx example #1329

Merged
merged 2 commits into from Aug 26, 2020
Merged

docs: add nginx example #1329

merged 2 commits into from Aug 26, 2020

Conversation

travisgroth
Copy link
Contributor

@travisgroth travisgroth commented Aug 24, 2020

Summary

Add an example configuration for nginx external auth

Checklist:

  • updated docs
  • ready for review

@codeclimate
Copy link

codeclimate bot commented Aug 24, 2020

Code Climate has analyzed commit 7b0ee79 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #1329 into master will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1329   +/-   ##
======================================
  Coverage    59.7%   59.7%           
======================================
  Files         108     108           
  Lines        8168    8168           
======================================
+ Hits         4879    4883    +4     
+ Misses       2853    2849    -4     
  Partials      436     436           
Impacted Files Coverage Δ
pkg/storage/redis/redis.go 72.7% <0.0%> (+1.5%) ⬆️

@travisgroth travisgroth added the docs Docs update required label Aug 25, 2020
@travisgroth travisgroth marked this pull request as ready for review August 25, 2020 17:28
@travisgroth travisgroth requested a review from a team as a code owner August 25, 2020 17:28
Copy link
Contributor

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Bobby DeSimone <bobbydesimone@gmail.com>
@travisgroth travisgroth added the backport 0-10-0 Backport to 0-10-0 release branch label Aug 26, 2020
@travisgroth travisgroth merged commit a69b995 into master Aug 26, 2020
@travisgroth travisgroth deleted the nginx_ext_example branch August 26, 2020 21:10
github-actions bot pushed a commit that referenced this pull request Aug 26, 2020
* docs: add nginx example

Co-authored-by: bobby <1544881+desimone@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Aug 26, 2020
* docs: add nginx example

Co-authored-by: bobby <1544881+desimone@users.noreply.github.com>
travisgroth added a commit that referenced this pull request Aug 26, 2020
* docs: add nginx example

Co-authored-by: bobby <1544881+desimone@users.noreply.github.com>

Co-authored-by: Travis Groth <travisgroth@users.noreply.github.com>
Co-authored-by: bobby <1544881+desimone@users.noreply.github.com>
travisgroth added a commit that referenced this pull request Aug 26, 2020
* docs: add nginx example

Co-authored-by: bobby <1544881+desimone@users.noreply.github.com>

Co-authored-by: Travis Groth <travisgroth@users.noreply.github.com>
Co-authored-by: bobby <1544881+desimone@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 0-10-0 Backport to 0-10-0 release branch docs Docs update required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants