Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add allowed_idp_claims docs #1665

Merged
merged 5 commits into from Dec 9, 2020
Merged

docs: add allowed_idp_claims docs #1665

merged 5 commits into from Dec 9, 2020

Conversation

travisgroth
Copy link
Contributor

@travisgroth travisgroth commented Dec 9, 2020 •
edited

Summary

Add documentation around allowed_idp_claims

Related issues

#1542

Checklist:

  • add related issues
  • updated docs
  • ready for review

@codeclimate
Copy link

codeclimate bot commented Dec 9, 2020 •
edited

Code Climate has analyzed commit df116c0 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Dec 9, 2020 •
edited

Codecov Report

Merging #1665 (df116c0) into master (58adeb5) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1665   +/-   ##
======================================
  Coverage    55.5%   55.5%           
======================================
  Files         126     126           
  Lines        9174    9174           
======================================
+ Hits         5093    5097    +4     
+ Misses       3590    3587    -3     
+ Partials      491     490    -1
Impacted Files Coverage Δ
pkg/storage/redis/redis.go 72.5% <0.0%> (+0.8%) ⬆️
internal/autocert/manager.go 64.4% <0.0%> (+1.4%) ⬆️

calebdoxsey
calebdoxsey approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@calebdoxsey calebdoxsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@travisgroth travisgroth marked this pull request as ready for review December 9, 2020 17:14
@travisgroth travisgroth requested a review from a team as a code owner December 9, 2020 17:14
@travisgroth travisgroth added docs Docs update required backport 0-11-0 labels Dec 9, 2020
@travisgroth travisgroth merged commit 82c7d1e into master Dec 9, 2020
@travisgroth travisgroth deleted the claims_docs branch December 9, 2020 17:16
github-actions bot pushed a commit that referenced this pull request Dec 9, 2020
@travisgroth @github-actions
docs: add allowed_idp_claims docs (#1665)
9589158
@github-actions github-actions bot mentioned this pull request Dec 9, 2020
Merged
travisgroth added a commit that referenced this pull request Dec 9, 2020
@github-actions @travisgroth
docs: add allowed_idp_claims docs (#1665) (#1667)
aa0eb09 
Co-authored-by: Travis Groth <travisgroth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebdoxsey calebdoxsey calebdoxsey approved these changes

@vihardesu vihardesu Awaiting requested review from vihardesu

Assignees
No one assigned
Labels
backport 0-11-0 docs Docs update required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@travisgroth @calebdoxsey