Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onelogin: fix default scopes for v2 #1896

Merged
merged 1 commit into from
Feb 17, 2021
Merged

onelogin: fix default scopes for v2 #1896

merged 1 commit into from
Feb 17, 2021

Conversation

calebdoxsey
Copy link
Contributor

Summary

The newer v2 OneLogin OIDC Connect API no longer supports offline_access:

Version 2.0 only.
When this scope is supplied with Password Grant a refresh_token allowing offline access will be returned.
Using this scope with Implicit or Authorization Code flow will cause an error.

This PR updates our onelogin code to remove offline access for the v2 URL.

Related issues

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the bug Something isn't working label Feb 16, 2021
@calebdoxsey calebdoxsey requested a review from a team as a code owner February 16, 2021 22:44
@codeclimate
Copy link

codeclimate bot commented Feb 16, 2021

Code Climate has analyzed commit 5c58817 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #1896 (0e1fd95) into master (5be71b8) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1896   +/-   ##
======================================
  Coverage    59.4%   59.4%           
======================================
  Files         138     138           
  Lines        9663    9663           
======================================
+ Hits         5743    5747    +4     
+ Misses       3320    3317    -3     
+ Partials      600     599    -1     
Impacted Files Coverage Δ
pkg/storage/redis/redis.go 74.2% <0.0%> (-1.1%) ⬇️
internal/databroker/server.go 51.1% <0.0%> (-0.8%) ⬇️
internal/autocert/manager.go 66.8% <0.0%> (+1.3%) ⬆️
internal/controlplane/xdsmgr/xdsmgr.go 81.3% <0.0%> (+5.8%) ⬆️

@desimone
Copy link
Contributor

\cc @zackb

@calebdoxsey calebdoxsey merged commit 64d247c into master Feb 17, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/1885 branch February 17, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants