Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add rewrite_response_headers to protobuf #1962

Merged
merged 1 commit into from Mar 5, 2021
Merged

Conversation

calebdoxsey
Copy link
Contributor

Summary

For #1961 I forgot to add the field to the protobuf.

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner March 5, 2021 20:30
@calebdoxsey calebdoxsey requested a review from wasaga March 5, 2021 20:30
@codeclimate
Copy link

codeclimate bot commented Mar 5, 2021

Code Climate has analyzed commit 742af9c and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #1962 (742af9c) into master (7f61070) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

@@           Coverage Diff            @@
##           master   #1962     +/-   ##
========================================
- Coverage    60.2%   60.1%   -0.2%     
========================================
  Files         148     148             
  Lines       10139   10151     +12     
========================================
- Hits         6108    6105      -3     
- Misses       3400    3414     +14     
- Partials      631     632      +1     
Impacted Files Coverage Δ
config/policy.go 79.3% <0.0%> (-4.4%) ⬇️
pkg/grpc/databroker/syncer.go 91.6% <0.0%> (-4.2%) ⬇️

@calebdoxsey calebdoxsey merged commit 46ae3cf into master Mar 5, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/566 branch March 5, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants