proxy: add nil check for fix-misdirected #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit c631b32 and detected 0 issues on this pull request. View more on Code Climate. |
desimone
approved these changes
Mar 30, 2021
Codecov Report
@@ Coverage Diff @@
## master #2040 +/- ##
========================================
- Coverage 59.3% 59.3% -0.1%
========================================
Files 158 158
Lines 10863 10863
========================================
- Hits 6447 6446 -1
- Misses 3675 3676 +1
Partials 741 741
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
fix-misdirected.luascript would sometimes result in an error message due to the dynamic metadata returning a nil table. Adding a nil check should fix the issue.I also added a unit test for this.
Related issues
Fixes #2038
Checklist
improvement/bug/ etc)