Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment: update get-envoy script and release hooks #2111

Merged
merged 1 commit into from Apr 21, 2021

Conversation

travisgroth
Copy link
Contributor

Summary

  • Refactor goreleaser hooks for split get/embed scripts
  • Update get-envoy script to pull from our binary source
  • Update get-envoy script to accept an optional target directory env var

Related issues

#1908

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@codeclimate
Copy link

codeclimate bot commented Apr 21, 2021

Code Climate has analyzed commit 140f7ce and detected 0 issues on this pull request.

View more on Code Climate.

@travisgroth travisgroth requested review from calebdoxsey and removed request for wasaga April 21, 2021 19:57
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #2111 (140f7ce) into master (3906b70) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #2111     +/-   ##
========================================
- Coverage    60.3%   60.2%   -0.1%     
========================================
  Files         165     165             
  Lines       11152   11152             
========================================
- Hits         6725    6723      -2     
- Misses       3652    3654      +2     
  Partials      775     775             
Impacted Files Coverage Δ
internal/controlplane/xdsmgr/xdsmgr.go 74.0% <0.0%> (-5.8%) ⬇️
pkg/storage/inmemory/backend.go 86.7% <0.0%> (-3.7%) ⬇️
pkg/storage/inmemory/stream.go 73.4% <0.0%> (+4.0%) ⬆️
pkg/grpc/databroker/syncer.go 96.2% <0.0%> (+6.2%) ⬆️

@travisgroth travisgroth merged commit 2b59db2 into pomerium:master Apr 21, 2021
@travisgroth travisgroth deleted the fix_goreleaser_embed branch April 21, 2021 20:00
travisgroth added a commit that referenced this pull request Apr 21, 2021
Co-authored-by: Travis Groth <travisgroth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants