Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPL: bubble up values, bug fixes #2213

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

calebdoxsey
Copy link
Contributor

@calebdoxsey calebdoxsey commented May 18, 2021

Summary

Several changes for the Pomerium Policy Language:

  1. Bubble up the values from rules to and, or, not and then to allow and deny. This is necessary because deny returns an HTTP status code and message.
  2. Fix several rules where we were using = but should've used ==
  3. Combine all the allow or deny rules into a complete definition using else blocks
  4. Fix the databroker helpers so that they don't allow null values. We were doing this in authz but it didn't get ported over. Also use = instead of :=.
  5. There was a bug in the user rule. It should be user.id not user_id.
  6. Sort the rules and assign them locations so we get deterministic ordering of rules in the formatted output.

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the bug Something isn't working label May 18, 2021
@calebdoxsey calebdoxsey requested a review from a team as a code owner May 18, 2021 16:07
@calebdoxsey calebdoxsey requested a review from wasaga May 18, 2021 16:07
@codeclimate
Copy link

codeclimate bot commented May 18, 2021

Code Climate has analyzed commit 341ef2a and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@calebdoxsey calebdoxsey merged commit bdccd4f into master May 18, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/407-ppl-bubble-up branch May 18, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants