envoy: add global response headers to local replies #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 3fa2a96 and detected 0 issues on this pull request. View more on Code Climate. |
desimone
approved these changes
May 20, 2021
calebdoxsey
deleted the
cdoxsey/2110-response-headers-for-unmatched-routes
branch
desimone
pushed a commit
that referenced
this pull request
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If envoy fails to match a request to a route it responds with a "local" reply. This PR adds a local reply configuration to add our global response headers to this reply.
Related issues
Fixes #2110
Checklist
improvement/bug/ etc)