Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin: use gopsutil v3 to fix arm issue #2245

Merged
merged 2 commits into from
May 28, 2021

Conversation

calebdoxsey
Copy link
Contributor

Summary

The darwin/arm64 build was failing with:

../../../../pkg/mod/github.com/shirou/gopsutil@v0.0.0-20190731134726-d80c43f9c984/process/process_darwin.go:595:34: undefined: KinfoProc

This should fix the issue by using the v3 API and removing getenvoy (which is no longer used?).

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the bug Something isn't working label May 28, 2021
@calebdoxsey calebdoxsey requested a review from a team as a code owner May 28, 2021 18:10
@calebdoxsey calebdoxsey requested a review from wasaga May 28, 2021 18:10
@codeclimate
Copy link

codeclimate bot commented May 28, 2021

Code Climate has analyzed commit 714f335 and detected 0 issues on this pull request.

View more on Code Climate.

@calebdoxsey calebdoxsey merged commit d538f1d into master May 28, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/darwin-arm-gopsutil branch May 28, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants