config: warn about unrecognized keys #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 21edf50 and detected 0 issues on this pull request. View more on Code Climate. |
desimone
reviewed
May 31, 2021
docs/reference/readme.md
Outdated
|
|
||
| These configuration variables are shared by all services, in all service modes. |
There was a problem hiding this comment.
Can you turn off your editors auto-formatter to isolate changes?
There was a problem hiding this comment.
Also, if there are changes to reference.md, they need to be made in settings.yaml then generate this file.
desimone
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Warn if some config keys cannot be recognized.
Also fixes few typos in the docs.
Related issues
Fixes https://github.com/pomerium/internal/issues/358 https://github.com/pomerium/internal/issues/413
Checklist
improvement/bug/ etc)