envoy: disable hot-reload for macos #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit fb1897e and detected 0 issues on this pull request. View more on Code Climate. |
wasaga
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disable envoy hot-reload for MacOS, because it doesn't appear to work. Instead we kill the previous process and start a brand new.
Also change the fatal "error retrieving subprocess status" to an error. For some reason on MacOS this will sometimes return "signal: killed". My search on google didn't turn up anything.
Related issues
Fixes https://github.com/pomerium/internal/issues/424
Fixes #2212
Checklist
improvement/bug/ etc)