tracing: support dynamic reloading, more aggressive envoy restart #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 0415fa5 and detected 0 issues on this pull request. View more on Code Climate. |
wasaga
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The zipkin trace exporter also started an HTTP reporter that needs to be terminated when a different trace provider is dynamically configured. This updates the code to better handle changes.
I also updated the envoy restart so that we more aggressively drain and terminate the original process. During hot-reload the old envoy process will continue to send tracing information to the previous zipkin URL, but once the new one takes over the new URL should be used.
I also updated the logging provider for zipkin so logs are JSON formatted.
Related issues
Fixes https://github.com/pomerium/pomerium-console/issues/1265
Checklist
improvement/bug/ etc)