Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocsp: reload on response changes #2286

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Conversation

wasaga
Copy link
Contributor

@wasaga wasaga commented Jun 11, 2021

Summary

Certificates with OCSP must-staple will become invalid and cause connection handshake failures unless an up to date OCSP response is stapled to it.

Related issues

Fixes #1946 https://github.com/pomerium/internal/issues/440

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga added the bug Something isn't working label Jun 11, 2021
@wasaga wasaga requested a review from a team as a code owner June 11, 2021 18:02
@wasaga wasaga requested a review from calebdoxsey June 11, 2021 18:02
@codeclimate
Copy link

codeclimate bot commented Jun 11, 2021

Code Climate has analyzed commit 4d5699b and detected 0 issues on this pull request.

View more on Code Climate.

@wasaga wasaga merged commit b372ab4 into master Jun 11, 2021
@wasaga wasaga deleted the wasaga/monitor-ocsp-updates branch June 11, 2021 19:58
@calebdoxsey calebdoxsey mentioned this pull request Sep 9, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCSP staple sometimes missing
2 participants