Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy: refactor envoy embedding #2296

Merged
merged 6 commits into from
Jun 15, 2021
Merged

Conversation

calebdoxsey
Copy link
Contributor

Summary

Use go:embed for embedding envoy.

Related issues

Fixes https://github.com/pomerium/internal/issues/435

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner June 14, 2021 20:03
@calebdoxsey calebdoxsey requested a review from wasaga June 14, 2021 20:03
@codeclimate
Copy link

codeclimate bot commented Jun 14, 2021

Code Climate has analyzed commit f3eb2eb and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@wasaga wasaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no compression?

@calebdoxsey calebdoxsey merged commit 9bce831 into master Jun 15, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/435-embed-envoy-v2 branch June 15, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants