Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorize: do not send redirects to gRPC #2314

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Conversation

wasaga
Copy link
Contributor

@wasaga wasaga commented Jun 25, 2021

Summary

According to https://chromium.googlesource.com/external/github.com/grpc/grpc/+/HEAD/doc/PROTOCOL-HTTP2.md

If Content-Type does not begin with “application/grpc”, gRPC servers SHOULD respond with HTTP status of 415 (Unsupported Media Type).

which hints that content-type should always be present for gRPC requests.

Related issues

Fixes https://github.com/pomerium/internal/issues/446

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga requested a review from a team as a code owner June 25, 2021 18:25
@wasaga wasaga requested a review from calebdoxsey June 25, 2021 18:25
@codeclimate
Copy link

codeclimate bot commented Jun 25, 2021

Code Climate has analyzed commit 7fdb786 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 64.708% when pulling 7fdb786 on wasaga/add-grpc-proto into 11a6193 on master.

@wasaga wasaga merged commit 7d0db7d into master Jul 6, 2021
@wasaga wasaga deleted the wasaga/add-grpc-proto branch July 6, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants