cli: use proxy from environment #2316
Conversation
|
|
|
Code Climate has analyzed commit 8235da4 and detected 0 issues on this pull request. View more on Code Climate. |
|
Hey @calebdoxsey what needs to happen to get this PR approved? Pomerium is an awesome project that we would love to use but not being able to use a proxy is a deal breaker for us. |
internal/authclient/authclient.go
Outdated
| @@ -120,6 +120,7 @@ func (client *AuthClient) runOpenBrowser(ctx context.Context, li net.Listener, s | |||
| } | |||
|
|
|||
| transport := &http.Transport{ | |||
| Proxy: http.ProxyFromEnvironment, | |||
There was a problem hiding this comment.
This makes sense to me. I wonder if a broader fix would be to use a Clone'd version of the default http transport http.DefaultTransport which also has some likely sane default timeouts and settings beyond Proxy?
There was a problem hiding this comment.
Yeah that sounds good to me. You mean something like this right?
transport := http.DefaultTransport.Clone()
transport.TLSClientConfig = client.cfg.tlsConfig
|
@tskinn -- This makes sense to me. Had one suggestion, but otherwise I think we can move forward. |
desimone
changed the title
|
Thanks @tskinn ! |
Summary
The existing implementation of pomerium-cli does not respect the http proxy env vars so here we add the default http.Transport behavior back with ProxyFromEnvironment.
Related issues
Checklist
improvement/bug/ etc)