Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: timeout in protobuf #2341

Merged
merged 1 commit into from
Jul 7, 2021
Merged

fix: timeout in protobuf #2341

merged 1 commit into from
Jul 7, 2021

Conversation

wasaga
Copy link
Contributor

@wasaga wasaga commented Jul 7, 2021

Summary

  1. Fix timeout propagation in protobuf
  2. Add allowWebsockets to timeout and idleTimeout tests

Related issues

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga added the bug Something isn't working label Jul 7, 2021
@wasaga wasaga requested a review from a team as a code owner July 7, 2021 15:59
@wasaga wasaga requested a review from calebdoxsey July 7, 2021 15:59
@codeclimate
Copy link

codeclimate bot commented Jul 7, 2021

Code Climate has analyzed commit a25f819 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 64.571% when pulling a25f819 on wasaga/btfix-timeout into 163e538 on master.

@wasaga wasaga merged commit 3073146 into master Jul 7, 2021
@wasaga wasaga deleted the wasaga/btfix-timeout branch July 7, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebdoxsey calebdoxsey calebdoxsey approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wasaga @coveralls @calebdoxsey