Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy: only check for pid with monitor #2355

Merged
merged 1 commit into from
Jul 13, 2021
Merged

envoy: only check for pid with monitor #2355

merged 1 commit into from
Jul 13, 2021

Conversation

calebdoxsey
Copy link
Contributor

@calebdoxsey calebdoxsey commented Jul 12, 2021 •
edited
Loading

Summary

Only check for pid with monitor. Ignore creation time.

Related issues

Fixes https://github.com/pomerium/internal/issues/424

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the bug Something isn't working label Jul 12, 2021
@calebdoxsey calebdoxsey requested a review from a team as a code owner July 12, 2021 21:18
@calebdoxsey calebdoxsey requested a review from wasaga July 12, 2021 21:18
@codeclimate
Copy link

codeclimate bot commented Jul 12, 2021

Code Climate has analyzed commit 893f84a and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 64.529% when pulling 893f84a on cdoxsey/424-gopsutil-is-running-error into 8e155bd on master.

@desimone desimone requested review from travisgroth and removed request for wasaga July 13, 2021 00:41
@calebdoxsey calebdoxsey merged commit 4c64daa into master Jul 13, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/424-gopsutil-is-running-error branch July 13, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisgroth travisgroth travisgroth approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebdoxsey @coveralls @travisgroth