Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoyconfig: only delete cached files, ignore noisy error #2356

Merged
merged 1 commit into from
Jul 13, 2021
Merged

envoyconfig: only delete cached files, ignore noisy error #2356

merged 1 commit into from
Jul 13, 2021

Conversation

calebdoxsey
Copy link
Contributor

Summary

Only delete cached files. Ignore noisy error.

Related issues

Fixes https://github.com/pomerium/internal/issues/451

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner July 12, 2021 21:24
@calebdoxsey calebdoxsey requested a review from wasaga July 12, 2021 21:24
@codeclimate
Copy link

codeclimate bot commented Jul 12, 2021

Code Climate has analyzed commit f56d669 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 64.649% when pulling f56d669 on cdoxsey/451-clear-envoy-file-cache-error into 8e155bd on master.

@calebdoxsey calebdoxsey merged commit 23552cf into master Jul 13, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/451-clear-envoy-file-cache-error branch July 13, 2021 15:58
@travisgroth travisgroth added the bug Something isn't working label Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desimone desimone desimone approved these changes

@wasaga wasaga Awaiting requested review from wasaga

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@calebdoxsey @coveralls @desimone @travisgroth