Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorize: decode CheckRequest path for redirect #2357

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

calebdoxsey
Copy link
Contributor

Summary

The envoy CheckRequest HTTP path comes in encoded:

path (string)
The request target, as it appears in the first line of the HTTP request. This includes the URL path and query-string. No decoding is performed.

So we need to store it as the RawPath instead of the Path.

Related issues

Fixes https://github.com/pomerium/internal/issues/468

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the bug Something isn't working label Jul 13, 2021
@calebdoxsey calebdoxsey requested a review from a team as a code owner July 13, 2021 15:56
@calebdoxsey calebdoxsey requested a review from wasaga July 13, 2021 15:56
@codeclimate
Copy link

codeclimate bot commented Jul 13, 2021

Code Climate has analyzed commit d813d45 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 64.421% when pulling d813d45 on cdoxsey/468-path-escape into 8973735 on master.

@calebdoxsey calebdoxsey merged commit b4b86dc into master Jul 13, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/468-path-escape branch July 13, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants