Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry: support b3 headers on gRPC server calls #2376

Merged
merged 1 commit into from Jul 20, 2021

Conversation

calebdoxsey
Copy link
Contributor

Summary

Envoy sometimes sends gRPC requests with b3 tags instead of grpc-trace-bin. This PR updates the code to support either.

Related issues

Fixes #2372

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the bug Something isn't working label Jul 19, 2021
@calebdoxsey calebdoxsey requested a review from a team as a code owner July 19, 2021 22:34
@calebdoxsey calebdoxsey requested a review from wasaga July 19, 2021 22:34
@codeclimate
Copy link

codeclimate bot commented Jul 19, 2021

Code Climate has analyzed commit e7c9ec7 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 65.39% when pulling e7c9ec7 on cdoxsey/2372-custom-trace-parsing into a020104 on master.

@calebdoxsey calebdoxsey merged commit fbf4426 into master Jul 20, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/2372-custom-trace-parsing branch July 20, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracing: spans are disjointed in jaeger / zipkin
3 participants