Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urlutil: improve error message for urls with port in path #2377

Merged
merged 1 commit into from
Jul 20, 2021
Merged

urlutil: improve error message for urls with port in path #2377

merged 1 commit into from
Jul 20, 2021

Conversation

calebdoxsey
Copy link
Contributor

Summary

Improve parse error message for URLs with port in path.

Related issues

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner July 20, 2021 13:30
@calebdoxsey calebdoxsey requested a review from wasaga July 20, 2021 13:31
@codeclimate
Copy link

codeclimate bot commented Jul 20, 2021

Code Climate has analyzed commit 1c8c49f and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 65.389% when pulling 1c8c49f on cdoxsey/1590-clarify-protocol-error-message into fbf4426 on master.

@calebdoxsey calebdoxsey merged commit 8a74fae into master Jul 20, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/1590-clarify-protocol-error-message branch July 20, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasaga wasaga wasaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@calebdoxsey @coveralls @wasaga @travisgroth