Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessions: add impersonate_session_id, remove legacy impersonation #2407

Merged
merged 6 commits into from
Jul 30, 2021
Merged

sessions: add impersonate_session_id, remove legacy impersonation #2407

merged 6 commits into from
Jul 30, 2021

Conversation

calebdoxsey
Copy link
Contributor

Summary

Add impersonate_session_id, remove legacy impersonation.

Related issues

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner July 29, 2021 20:50
@calebdoxsey calebdoxsey requested a review from wasaga July 29, 2021 20:50
@desimone desimone self-requested a review July 29, 2021 20:55
@codeclimate
Copy link

codeclimate bot commented Jul 29, 2021 •
edited
Loading

Code Climate has analyzed commit 8f7ad60 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

coveralls commented Jul 29, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 65.268% when pulling 8f7ad60 on cdoxsey/session-impersonation into 834fa85 on master.

desimone
desimone requested changes Jul 29, 2021
View reviewed changes
authenticate/handlers.go Outdated Show resolved Hide resolved
authorize/evaluator/opa/policy/headers.rego Show resolved Hide resolved
wasaga
wasaga approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@wasaga wasaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Side note - I don't understand why we do headers.rego instead of writing it in Go.

@calebdoxsey
Copy link
Contributor Author

@wasaga we used to do it in go. It was moved to rego with https://github.com/pomerium/internal/issues/278.

@calebdoxsey calebdoxsey merged commit 1a95036 into master Jul 30, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/session-impersonation branch July 30, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasaga wasaga wasaga approved these changes

@desimone desimone desimone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@calebdoxsey @coveralls @wasaga @desimone