-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry: try guess hostname or external IP addr for metrics #2412
Conversation
Code Climate has analyzed commit d6d8e41 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to guess a FQDN seems like a hopeless task.
If we really wanted to fix this we could use the pion library with ICE. But I still think the whole telemetry stack is way out of scope, so wouldn't advocate building our own UDP service mesh to get it to work.
I guess if we're ok with a half broken solution this is fine.
We will discuss on monday. |
It's understood that fqdn detection isn't totally reliable; the desire is to have telemetry work out of the box for users if/when possible. We will likely get feedback on common scenarios where it doesn't work and can fine tune from there. It does look like there's an issue with tests currently, though. |
…com/pomerium/pomerium into wasaga/telemetry-try-guess-hostname
Summary
Try guess hostname or external IP addr for metrics.
Related issues
Fixes https://github.com/pomerium/pomerium-console/issues/1490
Checklist
improvement
/bug
/ etc)